dynamic vlan with ath10k not working - regression

[Guenther Kelleter]

Hi

Since commit 7cebc8e2100626dc6981a3f53301058452953b9b, "Fix init of group state machine for static VLANs" dynamic VLAN isn't working with atk10k radio anymore. Parent commit works as expected.
Symptom is that neither wlanX-Y.<VLAN-ID> nor the corresponding vlan-bridge is created. Association fails.

I tried the same with ath9k radio: works as expected with both versions.

This is the relevant debug log of hostapd:

wlan0-2: STA 78:7e:61:61:15:a3 RADIUS: VLAN ID 20
VLAN: vlan_add_dynamic(vlan_id=20 ifname=wlan0-2.#)
nl80211: Create interface iftype 4 (AP_VLAN)
nl80211: Ignored event (cmd=7) for foreign interface (ifindex 60 wdev 0x0)
nl80211: New interface wlan0-2.20 created: ifindex=60
nl80211: Add own interface ifindex 60
nl80211: if_indices[16]: 5 34 58 59 60
nl80211: Add own interface ifindex 60
nl80211: ifindex 60 already in the list
VLAN: Set interface wlan0-2.20 up
WPA: Add group state machine for VLAN-ID 20
GMK - hexdump(len=32): [REMOVED]
Key Counter - hexdump(len=32): [REMOVED]
WPA: group state machine entering state GTK_INIT (VLAN-ID 20)
GTK - hexdump(len=16): [REMOVED]
IGTK - hexdump(len=16): [REMOVED]
WPA: group state machine entering state SETKEYSDONE (VLAN-ID 20)
wpa_driver_nl80211_set_key: ifindex=60 (wlan0-2.20) alg=3 addr=0x496be4 key_idx=1 set_tx=1 seq_len=0 key_len=16
nl80211: KEY_DATA - hexdump(len=16): [REMOVED]
   broadcast key
nl80211: set_key failed; err=-22 Invalid argument)
WPA: group state machine entering state FATAL_FAILURE
WPA: Ensure group state machine running for VLAN ID 20
WPA initialization for VLAN 20 failed (-1)
WPA: Try stopping group state machine for VLAN ID 20
WPA: Remove group state machine for VLAN-ID 20
WPA deinit of wlan0-2.20 failed
nl80211: wpa_driver_nl80211_if_remove(type=1 ifname=wlan0-2.20) ifindex=60 added_if=1
nl80211: Remove interface ifindex=60
nl80211: if_indices[16]: 5 34 58 59


Regards,
Günther