[PATCH] mesh: Report mesh peer AID to kernel

Bob Copeland me at bobcopeland.com
Thu Jun 30 04:00:35 PDT 2016

On Thu, Jun 30, 2016 at 06:03:24PM +0900, Masashi Honma wrote:
> Previously, mesh peer AID is not reported to kernel when local mesh
> STA is created without iw command. The mesh peer AID is needed by mesh
> peer power management functionality to identify a AID in a TIM
> element.
> This patch reports mesh peer AID to kernel.

The naming used in the patch is pretty confusing: we have "aid" already
and now "mesh_aid".  Which is which?  [Answer: aid is the association id
of the peer in our TIM (sta->aid in the kernel), while mesh_aid is our
association id in the peer's TIM (sta->mesh->aid).]

When it came to naming sta->mesh->aid I kind of punted and described
it in the comment struct, but if we're going to call it:

> +		    nla_put_u16(msg, NL80211_ATTR_MESH_PEER_AID,
> +				params->mesh_aid))

Then we might as well use "peer_aid" everywhere by analogy to peer linkid
since both are generated on the peer.

Bob Copeland %% http://bobcopeland.com/

More information about the Hostap mailing list