[PATCH v3 02/26] wpa_supplicant: ctrl handle IFNAME for global iface

[Janusz Dziedzic]

On 20 February 2016 at 16:18, Jouni Malinen <j at w1.fi> wrote:
> On Wed, Feb 17, 2016 at 01:14:05PM +0100, Janusz Dziedzic wrote:
>> In case of global ctrl iface return "global" as
>> a result of IFNAME.
>
> Why would this be done? "global" looks like a valid netdev name and
> getting "UNKNOWN COMMAND" response would already be available for
> recognizing the global interface.
>
>> +     } else if (os_strncmp(buf, "IFNAME", 6) == 0) {
>
Yes, I think we can skip this patch. I added this to handle wpa_cli
issue when connecting to global udp port.
But, this is not required for wpaspy and in case of wpa_cli proper
patch could be added to wpa_cli code.

> Please also note that this would match any string starting with
> "IFNAME". That does not sound correct regardless of whether there is
> use in returning the fixed "global" response.
>
> --
> Jouni Malinen                                            PGP id EFC895FA