[PATCH v3 14/26] hostapd: add INTERFACES ctrl command

[Jouni Malinen]

On Wed, Feb 17, 2016 at 01:14:17PM +0100, Janusz Dziedzic wrote:
> Print available interfaces with ctrl_iface.
> This is useful in case we using UDP CTRL and add
> interface using ADD command. After that we need to
> know which udp port we should use for this new
> added interface.

> diff --git a/hostapd/ctrl_iface.c b/hostapd/ctrl_iface.c
> +hostapd_global_ctrl_iface_interfaces(struct hapd_interfaces *interfaces,

> +	for (i = 0; i < interfaces->count; i++) {
> +		iface = interfaces->iface[i];
> +
> +		res = os_snprintf(pos, end - pos, "%s ctrl_iface=%s\n",
> +				  iface->conf->bss[0]->iface,
> +				  iface->conf->bss[0]->ctrl_interface);

This does not look at iface->conf->num_bss at all nor check whether
ctrl_interface is NULL. I'm not sure what this command is supposed to
return in multi-BSS configuration or if control interface is disabled,
but in any case, the current design does not look correct.
 
-- 
Jouni Malinen                                            PGP id EFC895FA