[PATCH v3 12/26] wpa_supplicant: udp ctrl show when ITERFACES cmd

Jouni Malinen j at w1.fi
Sat Feb 20 07:26:20 PST 2016


On Wed, Feb 17, 2016 at 01:14:15PM +0100, Janusz Dziedzic wrote:
> Show udp port when handle INTERFACES command.

> diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c
> @@ -9233,7 +9233,12 @@ static int wpa_supplicant_global_iface_interfaces(struct wpa_global *global,
> +#ifdef CONFIG_CTRL_IFACE_UDP
> +		res = os_snprintf(pos, end - pos, "%s ctrl_iface=%s\n",
> +				  wpa_s->ifname, wpa_s->conf->ctrl_interface);
> +#else
>  		res = os_snprintf(pos, end - pos, "%s\n", wpa_s->ifname);
> +#endif

Wouldn't this break all existing expectations on INTERFACES command
output format? It does not look good to return different values based on
which control interface backend is used.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list