[RESEND PATCH] wpa_supplicant: don't do <deny send_interface="..." /> in dbus service file

Jouni Malinen j at w1.fi
Sun Feb 7 08:51:31 PST 2016


On Wed, Jan 27, 2016 at 05:02:07PM +0100, Lubomir Rintel wrote:
> It does more than intended; apart from denying messages to that particular
> interface it also denies all messages non-qualified with an interface globally.
> This blocks messages completely unrelated to wpa_supplicant, such as
> NetworkManager communication with the VPN plugins.
> 
> From the dbus-daemon manual:
> 
>   Be careful with send_interface/receive_interface, because the
>   interface field in messages is optional. In particular, do NOT
>   specify <deny send_interface="org.foo.Bar"/>! This will cause
>   no-interface messages to be blocked for all services, which is almost
>   certainly not what you intended. Always use rules of the form: <deny
>   send_interface="org.foo.Bar" send_destination="org.foo.Service"/>
> 
> We can just safely remove those rules, since we're sufficiently protected
> by the send_destination matches and method calls are disallowed by default
> anyway.

Thanks, applied.
 
-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list