[PATCH] Changes to print KAY specific details via ctrl_iface

Jouni Malinen j at w1.fi
Mon Dec 19 12:56:26 PST 2016


On Fri, Dec 16, 2016 at 01:40:53AM +0530, Badrish Adiga H R wrote:
> Below are changes to print KAY specific details via ctrl_iface...

Thanks, applied with this fixed:

> diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c
> @@ -2050,6 +2050,12 @@ static int
> wpa_supplicant_ctrl_iface_status(struct wpa_supplicant *wpa_s,

> +#ifdef CONFIG_MACSEC
> +       ieee802_1x_kay_get_status(wpa_s->kay, pos, end - pos);
> +       if (res >= 0)
> +               pos += res;
> +#endif /* CONFIG_MACSEC */

That would use incorrect res value; the one returned by
ieee802_1x_kay_get_status() needs to be used here.. Was this patch
actually tested or even compile tested (a modern compiler would warn
about res being potentially used uninitialized here).

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list