[PATCH] writing and reading p2p_persistent_group bit in p2p.conf file

Jouni Malinen j at w1.fi
Sun Dec 11 10:21:15 PST 2016

On Wed, Dec 07, 2016 at 07:15:49PM +0530, Avichal Agarwal wrote:
> At the time of starting the wpa_supplicant it reads the persistent network
> Entries from p2p.conf file. Now p2p_persistent_group bit will register the
> the persistent network in dbus on the persistent object path.

> diff --git a/wpa_supplicant/config.c b/wpa_supplicant/config.c
> @@ -2061,6 +2061,7 @@ static const struct parse_data ssid_fields[] = {
>  	{ INT_RANGE(disabled, 0, 2) },
> +	{ INT_RANGE(p2p_persistent_group, 0, 1) },

Hmm.. This does not look correct to me. p2p_persistent_group is really
used only internally and I think it would be unwanted extra complexity
for existing configuration files to assume this is something that would
need to be set in existing persistent group entries. In addition, I
don't think it is good idea to expose option to clear
ssid->p2p_persistent_group from 1 to 0 (or the other direction, for that
matter) through the control interface.

The network entries used for persistent group credentials already have a
clear identifier: disabled=2. It would sound more convenient to set
ssid->p2p_persistent_group = 1 automatically based on the network block
having been stored with ssid->disabled == 2.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list