[PATCH 6/6] mka: pass full structures down the stack in ops callbacks

[Sabrina Dubroca]

2016-08-22, 21:08:09 +0300, Jouni Malinen wrote:
> On Mon, Aug 15, 2016 at 11:43:44AM +0200, Sabrina Dubroca wrote:
> > Instead of extracting some specific arguments, pass the structures down
> > to the driver and let it use what it needs.
> 
> > diff --git a/src/drivers/driver_macsec_qca.c b/src/drivers/driver_macsec_qca.c
> > @@ -31,6 +31,9 @@
> > +#include "pae/ieee802_1x_kay.h"
> > +#include "pae/ieee802_1x_kay_i.h"
> 
> The "_i.h" end in a header file name in wpa_supplicant is a convention
> that is used to identify a header file with internal definitions. Such
> header files are not supposed to be included into files in other
> directories.  In other words, if there is something that driver wrappers
> would need from ieee802_1x_kay_i.h, that something would need to be
> moved into ieee802_1x_kay.h or maybe even src/drivers/driver.h if this
> is part of a driver wrapper API.

Oh, ok.  It's for structs shared between the "core" KaY implementation
and the drivers.  I'd need to move "struct data_key" to
ieee802_1x_kay.h (or some other location) then.


Thanks,

-- 
Sabrina