[PATCH] wpa_supplicant: support Marvell roaming offload

[Jouni Malinen]

On Fri, Jul 08, 2016 at 04:24:47PM +0530, Amitkumar Karwar wrote:
> This patch adds function to download pmk/pmk_r0/pmk_r0_name for roaming
> offload and Marvell OUI vendor event handler.

This sounds like something that other drivers might want to use. Have
you considered proposing similar changes to the upstream Linux kernel
cfg80211/nl80211 instead of using vendor specific extensions?


> diff --git a/src/common/mrvl-vendor.h b/src/common/mrvl-vendor.h
> @@ -0,0 +1,28 @@
> +/*
> + * Marvell OUI and vendor specific assignments
> + */
> +#ifndef MRVL_VENDOR_H

Could you please add a copyright and license statement similar to the
one included in all other source code files here?

> diff --git a/src/drivers/driver_nl80211_event.c b/src/drivers/driver_nl80211_event.c
> @@ -1946,6 +1947,62 @@ static void nl80211_vendor_event_qca(struct wpa_driver_nl80211_data *drv,
>  	}
>  }
>  
> +static void mrvl_nl80211_key_mgmt_auth(struct wpa_driver_nl80211_data *drv,
> +				       const u8 *data, size_t len)

This should be within #ifdef CONFIG_DRIVER_NL80211_MRVL to match the
caller.

> +static void nl80211_vendor_event_mrvl(struct wpa_driver_nl80211_data *drv,
> +				      u32 subcmd, u8 *data, size_t len)
> +{
> +	switch (subcmd) {
> +#ifdef CONFIG_DRIVER_NL80211_MRVL
> +	case MRVL_NL80211_VENDOR_SUBCMD_KEY_MGMT_OFFLOAD:
> +		wpa_printf(MSG_DEBUG,
> +			   "nl80211: Received MRVL vendor event %u", subcmd);
> +		if (*data)

This could dereference a NULL pointer or read beyond the buffer since
data can be NULL and len can be zero.

-- 
Jouni Malinen                                            PGP id EFC895FA