[PATCH v2] supplicant: Allow custom probe and assoc req ie.

Ben Greear greearb at candelatech.com
Sun Apr 24 07:37:01 PDT 2016



On 04/24/2016 01:30 AM, Jouni Malinen wrote:
> On Tue, Apr 19, 2016 at 07:06:49AM -0700, Ben Greear wrote:
>> The "vendor_elem" array is in the wpa_s struct, but the config logic
>> deals with "struct wpa_config", which has no way to reference wpa_s as
>> far as I can tell.
>
> Correct.
>
>> Any opinion on moving wpa_s->vendor_elem to the wpa_config struct?
>>
>> Or, maybe add a back-pointer from wpa_config to the wpa_s?
>
> Why would either of those be needed? The new configuration parameters
> would be completely independent of wpa_s->vendor_elem, i.e., they are
> used only as a default value to set wpa_s->vendor_elem when bringing up
> an interface. No further changes to the configuration parameter during
> the lifetime of the interface would change wpa_s->vendor_elem and
> similarly, no VENDOR_ELEM* command would change the value of the
> configuration parameter.

Oh, I was thinking that the config file would write directly into the
vendor_elem array instead of storing a local copy.  I think I see what you are suggesting now...

Thanks,
Ben


-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com



More information about the Hostap mailing list