[PATCH 2/3] RADIUS: Fix possible memory leak

Ilan Peer ilan.peer at intel.com
Thu Apr 7 03:31:00 PDT 2016


From: Ayala Beker <ayala.beker at intel.com>

Fix possible memory leak in radius_msg_add_mppe_keys().

Signed-off-by: Ayala Beker <ayala.beker at intel.com>
---
 src/radius/radius.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/radius/radius.c b/src/radius/radius.c
index da978db..1a7f42c 100644
--- a/src/radius/radius.c
+++ b/src/radius/radius.c
@@ -1199,8 +1199,10 @@ int radius_msg_add_mppe_keys(struct radius_msg *msg,
 	vhdr = (struct radius_attr_vendor *) pos;
 	vhdr->vendor_type = RADIUS_VENDOR_ATTR_MS_MPPE_SEND_KEY;
 	pos = (u8 *) (vhdr + 1);
-	if (os_get_random((u8 *) &salt, sizeof(salt)) < 0)
+	if (os_get_random((u8 *)&salt, sizeof(salt)) < 0) {
+		os_free(buf);
 		return 0;
+	}
 	salt |= 0x8000;
 	WPA_PUT_BE16(pos, salt);
 	pos += 2;
-- 
1.9.1




More information about the Hostap mailing list