[PATCH] supplicant: Use ap_vendor_elements in probe and assoc requests.

Jouni Malinen j at w1.fi
Sat Apr 2 03:25:53 PDT 2016


On Fri, Apr 01, 2016 at 08:25:09PM -0400, greearb at candelatech.com wrote:
> This lets user specify additional IEs for probe requests and
> association requests.  This patch re-uses much of the existing
> ap_vendor_elements support in wpa_supplicant.

I could understand adding configuration option for additional IEs in
Probe Request and Association Request frames, but I don't understand why
this would reuse ap_vendor_elements which is both named and documented
as applying to AP and P2P GO mode. That's just asking for problems since
the existing parameter is already in use and the set of IEs in various
management frames is different. Even the Probe Request and Association
Request frame cases are so different, that it would likely make more
sense to have separate parameters for each of those.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list