[PATCH] DBus: allow "Get" paramter in Start [WPS] to get a valid random pin

Jouni Malinen j
Mon Sep 7 11:05:49 PDT 2015


On Wed, Jun 24, 2015 at 05:02:47AM +0000, Purushottam Kushwaha wrote:
> This is equivalent to "wps_pin get" on control interface. It will
> facilitate dbus applications in getting a valid random pin to start wps.

It sounds reasonable to provide similar functionality with D-Bus to
fetch a random PIN from wpa_supplicant without starting the actual WPS
operation. However, using the Start() method to do this sounds pretty
confusing. That method is documented to start a WPS configuration and
the Role argument is marked as a required argument. However, this change
would remove that requirement on Role and would make Start() not
actually start anything in case the Get="pin" dictionary value is
included.

Wouldn't a new method be cleaner way of doing this? The existing
mechanism already supports the case of selecting a random PIN, so the
new need here is only for the purpose of generating a random PIN without
starting WPS.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list