[PATCH] [DBus] Add support for vendor specific methods on dbus

[Jouni Malinen]

On Thu, Oct 29, 2015 at 06:12:52AM +0000, Avichal Agarwal wrote:
> this also includes dbus.doxygen

Thanks.

> Methods are
> 1.VendorElemAdd type "is" i=integer  s=string
> 2.VendorElemGet "i" i=integer  (output string)
> 3.VendorElemRem "is" i=integer s=string

> +	  <dt>s : ielems</dt>
> +	  <dd>Hexdump of Information Element(s).</dd>

This string part is making my question whether this is really the best
design for the D-Bus interface. I had not full realized this, but with
the documentation added, it became clear that this would be a hexdump of
the binary IEs. While that is needed for the ASCII text-based control
interface, the D-Bus interface does not have such constraints and we
use ay (array of bytes) type with number of other binary items.
Shouldn't these VendorElem* methods do the same instead of require the
application using them to convert between binary and ASCII hexdump?

The attach patch is a bit cleaned up version that I was considering to
write a hwsim test case for. Please use that for any updated version if
you agree with the s (hexdump) --> ay format change.

-- 
Jouni Malinen                                            PGP id EFC895FA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dbus-Add-support-for-vendor-specific-methods.patch
Type: text/x-diff
Size: 16799 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/hostap/attachments/20151031/160a8246/attachment.bin>