[PATCH 08/14] ctrl: Redirect global MGMT_TX and GET commands to P2P Device interface

[Peer, Ilan]

> -----Original Message-----
> From: Jouni Malinen [mailto:j at w1.fi]
> Sent: Wednesday, October 28, 2015 10:50
> To: Peer, Ilan
> Cc: hostap at lists.infradead.org; Stern, Avraham
> Subject: Re: [PATCH 08/14] ctrl: Redirect global MGMT_TX and GET
> commands to P2P Device interface
> 
> On Thu, Oct 22, 2015 at 02:11:31PM +0000, Peer, Ilan wrote:
> > > From: Jouni Malinen [mailto:j at w1.fi] On Wed, Oct 14, 2015 at
> > > 06:43:14PM +0300, Ilan Peer wrote:
> > > > diff --git a/wpa_supplicant/ctrl_iface.c
> > > > b/wpa_supplicant/ctrl_iface.c
> > > > wpas_global_ctrl_iface_redir_p2p(struct wpa_global *global,
> > > > +#ifdef CONFIG_TESTING_OPTIONS
> > > > +		"MGMT_TX ",
> > > > +		"GET ",
> > > > +#endif /* CONFIG_TESTING_OPTIONS */
> > >
> > > Neither of these does not seem correct to redirect to a P2P interface.
> > > These are in no way specific to P2P and especially MGMT_TX looks
> > > pretty strange on the global interface since it is specific to an interface.
> >
> > Would it be better to state the interface names explicitly? So wlanX would
> be used in case the P2P Device is not used, and p2p-dev otherwise?
> 
> Yes, the correct interface name would need to be specified in the test script.
> I'm not completely sure what test case operations this is needed in, so cannot
> comment on the proper way of handling it there, but I don't see a
> wpa_supplicant change to be the correct way to do this.
> 

Ok. Please drop these patches. We'll change the implementation and send a new patch set.

Thanks,

Ilan.