[PATCH 08/14] ctrl: Redirect global MGMT_TX and GET commands to P2P Device interface

[Peer, Ilan]

> -----Original Message-----
> From: Jouni Malinen [mailto:j at w1.fi]
> Sent: Friday, October 16, 2015 20:40
> To: Peer, Ilan
> Cc: hostap at lists.shmoo.com; Stern, Avraham
> Subject: Re: [PATCH 08/14] ctrl: Redirect global MGMT_TX and GET
> commands to P2P Device interface
> 
> On Wed, Oct 14, 2015 at 06:43:14PM +0300, Ilan Peer wrote:
> > Redirect MGMT_TX and GET commands from the global control interface to
> > the P2P Device interface, to support a configuration that uses a
> > dedicated P2P Device interface.
> >
> > The redirection of MGMT_TX is needed in tests that use MGMT_TX for
> > P2P, e.g., in gas_max_pending().
> >
> > The redirection of GET is needed in tests that try to get values
> > previously configured using SET, e.g.,  nfc_p2p_go_neg()
> 
> > diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c
> > @@ -9152,6 +9152,10 @@ static char *
> > wpas_global_ctrl_iface_redir_p2p(struct wpa_global *global,
> > +#ifdef CONFIG_TESTING_OPTIONS
> > +		"MGMT_TX ",
> > +		"GET ",
> > +#endif /* CONFIG_TESTING_OPTIONS */
> 
> Neither of these does not seem correct to redirect to a P2P interface.
> These are in no way specific to P2P and especially MGMT_TX looks pretty
> strange on the global interface since it is specific to an interface.
> 

Would it be better to state the interface names explicitly? So wlanX would be used in case the P2P Device is not used, and p2p-dev otherwise?

Thanks,

Ilan.