[PATCH] DEL char (ASCII 127 decimal) now escaped

Josh Lehan krellan
Mon Oct 12 14:18:35 PDT 2015


Hello!

While testing, I noticed that printf_encode() makes
control characters human-readable, with one exemption,
the DEL character (ASCII 127).

Assuming this exemption was unintentional, here is a trivial patch
to make it appear as an escaped \x7f instead of a literal
DEL character in the output.

I am trying to allow the choice of wireless network name and password
to be as binary-clean as possible, and this will help.

Thank you!

Josh Lehan

Signed-off-by: Josh Lehan <krellan at krellan.net>
---
 src/utils/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/utils/common.c b/src/utils/common.c
index 660e9fc..e74a2ae 100644
--- a/src/utils/common.c
+++ b/src/utils/common.c
@@ -498,7 +498,7 @@ void printf_encode(char *txt, size_t maxlen, const u8 *data, size_t len)
 			*txt++ = 't';
 			break;
 		default:
-			if (data[i] >= 32 && data[i] <= 127) {
+			if (data[i] >= 32 && data[i] <= 126) {
 				*txt++ = data[i];
 			} else {
 				txt += os_snprintf(txt, end - txt, "\\x%02x",
-- 
1.9.1




More information about the Hostap mailing list