[PATCH v2 03/12] P2PS: Add channel policy to PD Request

Peer, Ilan ilan.peer
Mon Oct 12 06:42:17 PDT 2015



> -----Original Message-----
> From: Jouni Malinen [mailto:j at w1.fi]
> Sent: Monday, October 12, 2015 16:40
> To: Peer, Ilan
> Cc: hostap at lists.shmoo.com
> Subject: Re: [PATCH v2 03/12] P2PS: Add channel policy to PD Request
> 
> On Mon, Oct 12, 2015 at 01:11:27PM +0000, Peer, Ilan wrote:
> > > From: Jouni Malinen [mailto:j at w1.fi] This could result in buffer
> > > write overflow due to uninitialized 'size'
> > > variable. It needs to be set to the maximum number of entries in
> > > pref_freq_list before this call. I'll fix this with "size =
> > > P2P_MAX_PREF_CHANNELS;" before the call.
> >
> > Hmm .. I might be missing something, but you eventually did not have this
> change. Is it intentional?
> 
> It's there in the commit:
> http://w1.fi/cgit/hostap/tree/wpa_supplicant/p2p_supplicant.c?id=ebd32943
> cb986c4864a384ce4b9abf5a7d99bced#n647
> 

Got it. 10x.

Ilan.



More information about the Hostap mailing list