[PATCH 0/9] Removing code at random (was Refactor CTRL UDP (remote) path)

Sergio NNX sfhacker
Mon Oct 5 16:24:09 PDT 2015


> Have you tested this on Windows or any non-Linux platform?
...
...
> Please check with all other platforms than Linux.. There was a reason
> for me adding that check, but it was a long time ago, so I don't
> remember the details. Like I said, this most certainly must not be
> removed as part of a cleanup patch.

> The main reason for adding the UDP backend was to work on Windows. Named
> pipe version came after that and named pipes were not available on all
> Windows versions (e.g., WinCE, if I remember correctly). In other words,
> I'm not going to be accepting significant UDP control interface changes
> unless they have been verified to work on various platforms like WinCE.

If you don't mind me asking ... who has asked you to start removing code at random? 
Are you developer/tester for this project? There's plenty of code which needs refactoring.
Take, for instance, edit_readline.c file, it doesn't work on some platforms. To my mind,
improving existing source code has more priority than removing 'still in use' code!. 
Secondly, it is a good practice to ask people around before getting rid of functionality.

Should you require further assistance, do not hesitate to contact me off list.

Ciao.

 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.shmoo.com/pipermail/hostap/attachments/20151006/d9ef7e5a/attachment-0001.htm>



More information about the Hostap mailing list