[PATCH 00/23] P2PS bug fix and channel handling

[Jouni Malinen]

On Thu, Sep 24, 2015 at 08:37:50PM +0300, Ilan Peer wrote:
> The patch set includes:
> 
> 1. Fix P2PS bugs
> 2. Some cleanups and re-factoring for P2PS code.
> 3. P2PS channel selection handling, that also takes into consideration
>    used channels etc.

There are number of issues in this patch set.. At minimum, patches are
split incorrectly in a way that introduce significant issues (NULL
pointer dereferences, etc.) in the middle of the series while fixing
(but not necessarily for all issues..) things in later patches. I tried
to fix these, but gave up after the issues I noted in 11/23.

You can find the latest snapshot of the patches from my work branch
here: http://w1.fi/p/p2ps/

Could you please take another look at how the patches are split and
address the FIX comments on 11/23? I think I'm fine with the first ten
patches after the fixes and cleanup I did. I did not yet look at patches
12-23 in any real detail.

Please also note that two test cases introduced in patch 23/23 fail for
me every time: p2ps_channel_active_go_and_station_same and
p2ps_channel_both_connected_same

(both fail with "Exception: P2P-GROUP-STARTED timeout on
02:00:00:00:00:00")

I'm dropping these from my queue now. Please let me know if you want to
get the patches 1-10 applied as-is and then resubmit the rest after the
issues listed above have been addressed.
 
-- 
Jouni Malinen                                            PGP id EFC895FA