[PATCH 1/9] wpa_supplicant: use getaddrinfo() when UDP ctrl interface
Jouni Malinen
j
Mon Oct 5 02:20:56 PDT 2015
On Mon, Oct 05, 2015 at 07:14:04AM +0200, Janusz Dziedzic wrote:
> I am not sure this is really required while we will listen only on
> 127.0.0.1 and will not accept remote connection. I suspect IP stack
> already will care about it.
> Even without this check I wasn't able to connect to such UDP port from
> remote machine - seems IP stack handle this correctly (hints.ai_flags
> = AI_PASSIVE works fine).
>
> udp 0 0 127.0.0.1:9877 0.0.0.0:*
> udp 0 0 127.0.0.1:9878 0.0.0.0:*
>
> I suspect this check wasn't needed, or I miss something?
Please check with all other platforms than Linux.. There was a reason
for me adding that check, but it was a long time ago, so I don't
remember the details. Like I said, this most certainly must not be
removed as part of a cleanup patch.
Based on this, I'm dropping this patch set and the following patch set
that was based on this. Feel free to resubmit if this type of issues are
addressed. If _any_ of the existing security related checks are removed,
such removal need to be clearly presented in separate patches that
describe why the check is removed.
--
Jouni Malinen PGP id EFC895FA
More information about the Hostap
mailing list