nl80211: delete interface from bridge before removing the interface

[Yoel D.]

No, I didn't experience any functionality issues.

Nonetheless, after switching the invocation order of the functions
nl80211_remove_iface() and linux_br_del_if() the log entry disappears.
However, I'm unsure whether this patch could prove problematic under a
setup different than mine.


On Sun, Nov 1, 2015 at 12:00 AM, Jouni Malinen <j at w1.fi> wrote:
> On Sat, Oct 10, 2015 at 09:24:30PM +0300, Yoel D. wrote:
>> I've encountered the following error during hostapd shutdown process:
>>
>>     hostapd: nl80211: Failed to remove interface wlan0-1 from bridge
>> br0: No such device
>>
>> I think that this error occurs because the function
>> wpa_driver_nl80211_if_remove() removes the specified interface from
>> the host via the function nl80211_remove_iface() before deleting it
>> from the bridge via the function linux_br_del_if().
>>
>> Thus, when the function linux_br_del_if() is finally invoked in the
>> next few lines of code, the aforementioned error is raised since the
>> interface no longer exists.
>
> Does this cause any real issue to functionality apart from seeing that
> entry in debug log? I'm pretty sure this is not the only case where
> similar debug entries can be seen since the operation is not really
> needed in some cases.
>
> --
> Jouni Malinen                                            PGP id EFC895FA