p2p_mgmt interface and tdls_init

[Krishna Chaitanya]

On Thu, Jun 25, 2015 at 10:46 PM, Arend van Spriel <arend at broadcom.com> wrote:
> On 06/25/15 19:05, Krishna Chaitanya wrote:
>>
>> On Thu, Jun 25, 2015 at 10:32 PM, Arend van Spriel<arend at broadcom.com>
>> wrote:
>>>
>>> On 06/25/15 17:10, Krishna Chaitanya wrote:
>>>>
>>>>
>>>> On Thu, Jun 25, 2015 at 8:21 PM, Arend van Spriel<arend at broadcom.com>
>>>> wrote:
>>>>>
>>>>>
>>>>> On 06/25/15 16:47, Arend van Spriel wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>> On 06/25/15 16:21, Krishna Chaitanya wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I wanted to know the reason for blocking TDLS L2 Packet registration
>>>>>>> if the driver doesn't support
>>>>>>> dedicated p2p interface.
>>>>>>>
>>>>>>> this was introduced in this commit
>>>>>>> http://lists.shmoo.com/pipermail/hostap/2013-May/028008.html
>>>>>>>
>>>>>>
>>>>>> The intention was to block it for the dedicated p2p interface as it is
>>>>>> not transporting data and looking at the patch it is doing that, but I
>>>>>> might be wrong.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Looking at it again I support "dedicated p2p interface" is not same as
>>>>> P2P
>>>>> device interface. The patch avoids l2 for both, but for "dedicated p2p
>>>>> interface" it was already true before this patch. But the flag is a
>>>>> driver
>>>>> flag so not sure if that is a correct check.
>>>>
>>>>
>>>> Currently the check is as below: It checks for both DRIVER capability
>>>> and adding p2p_dev interface.
>>>>
>>>> #ifdef CONFIG_TDLS
>>>>           if ((!iface->p2p_mgmt ||
>>>>                !(wpa_s->drv_flags&
>>>>                  WPA_DRIVER_FLAGS_DEDICATED_P2P_DEVICE))&&
>>>>               wpa_tdls_init(wpa_s->wpa))
>>>>                   return -1;
>>>> #endif /* CONFIG_TDLS */
>>>>
>>>> So is my understanding, this check is to avoid
>>>> registering for EAPOL/TDLS framesfor P2P_DEV interface, correct?
>>>
>>>
>>>
>>> Correct. The above deals with TDLS part although the check for drv_flags
>>> was
>>> not in my patch.
>>
>> Yes, this code is from ToT.
>>>
>>> I think it is allow tdls operation for non-p2pdev interface
>>> that is assigned to be used for p2p mgmt.
>>
>> Not sure that is possible, using a p2p interface and invoking
>> TDLS, but yes this check allows that.
>
>
> As Jouni explained to me once any interface could be p2p *management*
> interface on their equipment. So a sta interface wlan0 could be assigned as
> p2p *management* interface in wpa_supplicant dealing with discovery and
> group negotiation, etc. while being connected to an AP. The code above
> allows for the regular sta traffic to setup a TDLS connection.
Yes, i understand. We also use the wlan0-STA interface for p2p
management, we can use TDLS after the p2p mgmt operatons
are done, but is it possible for concurrent use of p2p_mgmt and
TDLS on a STA interface while connected to AP?
STA + P2P MGMT + TDLS?