[PATCH] wpa_supplicant: typo in wpa_scan_result_compar
Hahn, Maital
maitalm
Wed Jul 8 06:13:11 PDT 2015
Typo in wpa_scan_result_compar() causes wrong scan results sorting
(and wrong roaming decision)
Signed-off-by: Maital Hahn <maitalm at ti.com>
---
wpa_supplicant/scan.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
mode change 100644 => 100755 wpa_supplicant/scan.c
diff --git a/wpa_supplicant/scan.c b/wpa_supplicant/scan.c
old mode 100644
new mode 100755
index b429951..6e39c2a
--- a/wpa_supplicant/scan.c
+++ b/wpa_supplicant/scan.c
@@ -1717,7 +1717,7 @@ static int wpa_scan_result_compar(const void *a, const void *b)
snr_a_full = wa->snr;
snr_a = MIN(wa->snr, GREAT_SNR);
snr_b_full = wb->snr;
- snr_b = MIN(wa->snr, GREAT_SNR);
+ snr_b = MIN(wb->snr, GREAT_SNR);
} else {
/* Level is not in dBm, so we can't calculate
* SNR. Just use raw level (units unknown). */
--
1.7.9
-----Original Message-----
From: Jouni Malinen [mailto:j at w1.fi]
Sent: Wednesday, July 08, 2015 3:36 PM
To: Hahn, Maital
Cc: hostap at lists.shmoo.com
Subject: Re: wpa_supplicant: typo in wpa_scan_result_compar() causes wrong scan results sorting (and wrong roaming decision)
On Wed, Jul 08, 2015 at 11:26:53AM +0000, Hahn, Maital wrote:
> diff --git a/wpa_supplicant/scan.c b/wpa_supplicant/scan.c
> --- a/wpa_supplicant/scan.c
> +++ b/wpa_supplicant/scan.c
> @@ -1717,7 +1717,7 @@ static int wpa_scan_result_compar(const void *a,
> const void *b)
Could you please read the top level CONTRIBUTIONS file and send this with a Signed-off-by: line in the commit message as described in that file so that I can apply the changes?
--
Jouni Malinen PGP id EFC895FA
More information about the Hostap
mailing list