[PATCH] Removing redundant commands in wpa_cli

Jouni Malinen j
Fri Apr 3 01:38:04 PDT 2015

On Fri, Mar 27, 2015 at 12:36:04PM +0100, Ola Olsson wrote:
> Fair enough, I see your point. I am not sure about your view regarding
> backward compatibility though, but I'll include a new patch removing the
> commands in wpa_supplicant as well. Use it if you want.

I was thinking of applying this since no one identified any users for
the removed commands. However, when I went through the hwsim test case
updates to use the SET command for these, number of behavior differences
came up. The value range validation steps are not done with the SET
commands and more importantly, the extra operations for AP_SCAN are not
covered. While it would be possible to modify SET handler to do same,
I'm not sure this is really desirable and anyway, taken into account
that this is only cleanup and not a critical fix, I'm tempted to drop
this change now (I'm taking the typo fix for wpa_cli.c, though, as a
separate patch).
Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list