[PATCH 4/4] SAE: Fix auth_transaction error handling

[Jouni Malinen]

On Tue, Nov 25, 2014 at 11:04:43AM +0900, Masashi Honma wrote:
> If auth_transaction is not commit and confirm, replies with the same
> auth_transaction. It causes continuous frame exchange. So reply with commit
> message.

> diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c
> @@ -733,6 +733,8 @@ static void handle_auth_sae(struct hostapd_data *hapd, struct sta_info *sta,
>  			       HOSTAPD_LEVEL_DEBUG,
>  			       "unexpected SAE authentication transaction %u",
>  			       auth_transaction);
> +		auth_transaction = 1;
> +		data = auth_build_sae_commit(hapd, sta, 0);
>  		resp = WLAN_STATUS_UNKNOWN_AUTH_TRANSACTION;
>  	}

This does not look correct. Commit fields would not be included in
Authentication frame with that status code and I don't think changing
the auth transaction number would be ideal either when indicating that
the authentication transaction was incorrect.

I'm not sure how this could cause continuous frame exchange. What is in
the other end replying to this message and generating the invalid SAE
auth transaction number in the first place? That should be fixed, not
this response..
 
-- 
Jouni Malinen                                            PGP id EFC895FA