[PATCH 2/4] SAE: Fix Anti-Clogging Token request frame format
Jouni Malinen
j
Tue Nov 25 05:57:57 PST 2014
On Tue, Nov 25, 2014 at 11:04:41AM +0900, Masashi Honma wrote:
> This patch inserts Finite Cyclic Group to Anti-Clogging Token request frame
> because IEEE Std 802.11-2012, Table 8-29 says "Finite Cyclic Group is present
> if Status is zero or 76.".
> + if (pos + 2 > end) {
> + wpa_printf(MSG_ERROR, "SAE: Too short "
> + "anti-clogging token request");
> + data = auth_build_sae_commit(hapd, sta, 0);
> + resp = WLAN_STATUS_UNSPECIFIED_FAILURE;
> + goto reply;
> + }
> + resp = sae_group_allowed(sta->sae,
> + hapd->conf->sae_groups,
> + WPA_GET_LE16(pos));
> + if (resp != WLAN_STATUS_SUCCESS) {
> + wpa_printf(MSG_ERROR, "SAE: Invalid group in "
> + "anti-clogging token request");
> + data = auth_build_sae_commit(hapd, sta, 0);
> + goto reply;
> + }
Including SAE commit in these two cases with non-zero (and not 76 for
that matter) status code does not look correct. I'll drop the
auth_build_sae_commit() call from these two locations.
--
Jouni Malinen PGP id EFC895FA
More information about the Hostap
mailing list