[PATCH 2/7] p2p: Add a utility function to retrieve local GO device address
Tomasz Bursztyka
tomasz.bursztyka
Tue May 27 03:32:32 PDT 2014
Hi Jouni,
> This function is named very confusingly. "device_address" seems to point
> towards P2P Device Address, but this is clearly returning a P2P
> Interface Address.
That's a bug in the previous patch indeed.
> In addition, it should be understood that more than a
> single group may match, i.e., this function would return_a_ local P2P
> Interface Address instead of_the_ address. This may still be useful,
> but it would be better to rename the function and note that possibility
> of multiple matches even if it is a bit unlikely to show up in practical
> use cases.
I see, I'll try to come with something that can iterate on all groups or
some sort.
Basically, what I want is in DBus API part to retrieve all group the
peer is part of (as a client or a GO)
for that I need the wpa_s the group is related to to be able to provide
the object path of the group then.
This patch, returning the interface address makes is flawed anyway, and
as you said I need to loop
on all possible groups due to the multi group case.
Tomasz
More information about the Hostap
mailing list