[PATCH 1/1] P2P: Addressing few issues seen with Broadcast SD

Jouni Malinen j
Thu Jan 30 05:06:05 PST 2014


On Thu, Jan 23, 2014 at 08:41:14PM +0530, Jithu Jance wrote:
> 1) Suppose we have multiple peers and we have peers advertising
> SD capability, but no services registered for adverstising.
> In this case, even if there are mutliple broadcast queries set,
> we might end up sending only the lastly added Broadcast to the
> same device (Since SD_INFO won't get set for the first broadcast)
> 
> 2) Some times it is seen that before advancing to next device in the
> list, the scan results come and updates SD_SCHEDULE flag. This will
> result in sending the already sent query to the same device without
> giving chance to other devices. This issue again is seen with peer
> devices advertising SD capability without any services registered.
> 
> Please see whether the patch is fine.

It looks like this breaks six out of the eight P2P SD regression test
cases:
http://buildbot.w1.fi/hwsim/results.php?run=1391084937

As such, I had to drop this for now. I have not yet looked at the
details, but it looks clear that some changes are needed to avoid these
regressions.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list