[PATCH] wpa_supplicant: systemd service directives

[Mark Oteiza]

Holger Schurig <holgerschurig at gmail.com> writes:

>> $ man systemd.unit
>> No manual entry for systemd.unit
>
> It seems that you don't run systemd, because this man page comes with
> systemd. You can find all of it's manpages online as well, see
> http://0pointer.de/public/systemd-man/
>
> The one in question is
> http://0pointer.de/public/systemd-man/systemd.unit.html.

In addition to the documentation, perhaps examples from other projects
will help show how wpa_supplicant's dbus service is fine; the others
misuse Alias.

[/usr/lib/systemd/system]$ find -type f -name '*.service' -exec grep
'Alias' {} +
./wpa_supplicant at .service:Alias=multi-user.target.wants/wpa_supplicant at wlan0.service
./wpa_supplicant.service:Alias=dbus-fi.epitest.hostap.WPASupplicant.service
./avahi-daemon.service:Alias=dbus-org.freedesktop.Avahi.service
./wpa_supplicant-nl80211 at .service:Alias=multi-user.target.wants/wpa_supplicant-nl80211 at wlan0.service
./wpa_supplicant-wired at .service:Alias=multi-user.target.wants/wpa_supplicant-wired at wlan0.service

[/usr/lib/systemd/system]$ find -type f -name '*.service' -exec grep
'WantedBy' {} +
./sshd.service:WantedBy=multi-user.target
./ntpd.service:WantedBy=multi-user.target
./iptables.service:WantedBy=multi-user.target
./rfkill-block at .service:WantedBy=multi-user.target
./dhcpcd at .service:WantedBy=multi-user.target
./rsyncd.service:WantedBy=multi-user.target
./krb5-kpropd.service:WantedBy=multi-user.target
./systemd-readahead-drop.service:WantedBy=system-update.target
./dhcpcd.service:WantedBy=multi-user.target
./ftpd.service:WantedBy=multi-user.target
./lvm-monitoring.service:WantedBy=sysinit.target
./krb5-kadmind.service:WantedBy=multi-user.target
./wpa_supplicant.service:WantedBy=multi-user.target
./systemd-readahead-replay.service:WantedBy=default.target
./xinetd.service:WantedBy=multi-user.target
./ip6tables.service:WantedBy=multi-user.target
./getty at .service:WantedBy=getty.target
./avahi-daemon.service:WantedBy=multi-user.target
./atop.service:WantedBy=multi-user.target
./envoy at .service:WantedBy=multi-user.target
./console-shell.service:WantedBy=getty.target
./systemd-readahead-collect.service:WantedBy=default.target
./cpupower.service:WantedBy=multi-user.target
./bitlbee.service:WantedBy=multi-user.target
./lightd.service:WantedBy=multi-user.target
./debug-shell.service:WantedBy=sysinit.target
./connman-vpn.service:WantedBy=multi-user.target
./console-getty.service:WantedBy=getty.target
./gpm.service:WantedBy=multi-user.target
./ifplugd at .service:WantedBy=multi-user.target
./avahi-dnsconfd.service:WantedBy=multi-user.target
./nginx.service:WantedBy=multi-user.target
./mdadm.service:WantedBy=multi-user.target
./nscd.service:WantedBy=multi-user.target
./connman.service:WantedBy=multi-user.target
./rfkill-unblock at .service:WantedBy=multi-user.target
./krb5-kdc.service:WantedBy=multi-user.target
./mpd.service:WantedBy=multi-user.target
./ntpdate.service:WantedBy=multi-user.target
./vnstat.service:WantedBy=multi-user.target
./ppp at .service:WantedBy=multi-user.target

> But with all of this info, I don't see why this comment is necessary.
> And I don't know why the patched unit files are "systemd unit
> templates" (they use %I inside),but why they aren't named like
> template units: they lack the @ in their filename.

They are .in files, the build system renames them.