[PATCH] l2_packet: fix eloop leak when using l2_packet_none

Maxime Bizon mbizon
Mon Apr 14 04:48:42 PDT 2014

On Mon, 2014-04-14 at 00:20 +0300, Jouni Malinen wrote:

> What are you using l2_packet_none.c for? It is just a minimal template
> showing how an l2_packet wrapper could be implemented.

if you don't have CONFIG_L2_PACKET=y, it happens to use l2_packet_none
implementation automatically

I don't have CONFIG_RSN_PREAUTH so it is not selected automatically

the code looked more to me like a "do nothing" layer instead of a
reference implementation

> Would probably be more valuable for the example to maintain these calls
> in the file somehow, e.g., by making registration use something like "if
> (l2->fd >= 0)" as the condition (i.e., compiler will remove it, but does
> not complain about unused static function).

I've not tested this, but since my eloop patch was applied (assert(fd !=
-1)), usage of l2_packet_none should not be possible anymore.

maybe we should leave l2_packet_none as-is or rename it and use empty
static inline functions when we don't need it ?


More information about the Hostap mailing list