[PATCH v5 00/22] Tagged VLAN support

Jouni Malinen j
Sat Nov 23 14:19:13 PST 2013

On Tue, Nov 19, 2013 at 08:46:39PM +0100, Michael Braun wrote:
> this patch series adds support for tagged VLANs.
> Changes in v5:
>  - vlan helper functions are no longer inline
>  - remove typedef vlan_t
>  - remove kernel bug workaround
>  - rebase to HEAD

I'm sorry but it would take me hours to clean these up into a state that
I could consider applying and since I don't have such extra time I'm
going to drop this set.

If you want to get this in, you will need to clean this up to match
coding style in hostapd and to merge the patches to make sense. hostapd
and wpa_supplicant need to compile between each individual patch in the
set. There is no point in splitting the use-new-VLAN-data-type into
close to ten patches. src/common/vlan.c is odd location for the new file
since it is really very much specific to AP mode (src/ap/vlan.c would be
better location).

Please also start with much smaller set at a time. I've tried to start
getting the last couple of rounds in, but always ended up in the same
state where something did not make sense and had to stop after
considerable amount of work. I'm not going to do that again, so until
there is a small and clean set of patches that provide reasonable
change, I will have to ignore these. Feel free to keep the full set
available somewhere, but just sent couple of patches at a time to the
mailing list until those get committed.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list