[PATCH] Android: Revert static field back to send_and_recv_msgs()

Jouni Malinen j
Fri Nov 22 13:10:06 PST 2013

On Fri, Nov 22, 2013 at 12:39:07PM -0800, Dmitry Shmidt wrote:
> diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
> @@ -625,10 +625,7 @@ static int send_and_recv_msgs_global(struct nl80211_global *global,
> -#ifndef ANDROID_P2P
> -static
> -#endif /* ANDROID_P2P */
> -int send_and_recv_msgs(struct wpa_driver_nl80211_data *drv,
> +static int send_and_recv_msgs(struct wpa_driver_nl80211_data *drv,
>  		       struct nl_msg *msg,
>  		       int (*valid_handler)(struct nl_msg *, void *),
>  		       void *valid_data)

I would certainly like to drop this, but I see send_and_recv() still
being used from
hardware/ti/wlan/mac80211/wpa_supplicant_lib/driver_mac80211_nl.c in
Android 4.3. Those uses seem to have disappeared in 4.4 which is quite

My goal is to maintain build compatibility for the last two AOSP
releases. Though, in this specific case, I just added that patch, so it
is not like removing this today really would result in anything being
worse than yesterday, so I think I'll go ahead and apply this.
Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list