[PATCH] wpa_supplicant: don't try to stop sched scan when initialization fails

Jouni Malinen j
Tue Nov 5 00:45:08 PST 2013

On Sun, Nov 03, 2013 at 03:27:59PM +0200, Ilan Peer wrote:
> From: Luciano Coelho <luciano.coelho at intel.com>
> If something goes wrong during initialization, we were trying to stop
> schedule scan (and thus read data from wpa_s->drv_priv), but the
> driver data doesn't exist, so we were segfaulting.  Fix this by not
> trying to stop sched scans if the private driver data doesn't exist.

Wasn't this issue introduced by the earlier commit in this set
("wpa_supplicant: fix 2 bugs in cancel sched scan")? Before that,
wpa_supplicant_cancel_sched_scan() exited immediately on
!wpa_s->scan_scanning and I'd assume that could not be set without the
driver having been initialized.. In other words, this commit should
really be merged to the other one. That said, it would probably make
sense to merge all these three sched_scan commits (i.e., also
"wpa_supplicant: cancel sched scan on all interfaces") since they seem
to be very much related and addressing issues from the previous commit.

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list