[PATCH] nl80211: Support splitting wiphy information in dumps
Johannes Berg
johannes
Wed Feb 20 08:27:01 PST 2013
On Wed, 2013-02-20 at 16:02 +0100, Dennis H Jensen wrote:
> This implements support for the new NL80211_ATTR_SPLIT_WIPHY_DUMP in
> nl80211 to handle wiphy information that cannot fit in one message.
Looks good to me, one small comment below:
> - if (send_and_recv_msgs(drv, msg, wiphy_info_handler, info) == 0)
> + if (send_and_recv_msgs(drv, msg, wiphy_info_handler, info) == 0) {
[...]
> return 0;
> + }
Instead of increasing the indentation here and getting strangely split
lines, it'd probably be better to do
if (send_and_recv_msgs())
return -1;
...
return 0;
nla_put_failure:
nlmsg_free(msg)
return -1;
}
johannes
More information about the Hostap
mailing list