[PATCH 3/7] Adding AutoScan interface method to set or unset autoscan parameters

Jouni Malinen j
Tue Jun 26 09:04:25 PDT 2012


On Tue, Jun 26, 2012 at 11:05:48AM +0300, Tomasz Bursztyka wrote:
> diff --git a/wpa_supplicant/dbus/dbus_new_handlers.c b/wpa_supplicant/dbus/dbus_new_handlers.c
> +DBusMessage * wpas_dbus_handler_autoscan(DBusMessage *message,
> +					 struct wpa_supplicant *wpa_s)
> +{

> +	if (wpa_s->conf->autoscan != NULL) {
> +		os_free(wpa_s->conf->autoscan);
> +		wpa_s->conf->autoscan = NULL;
> +	}

I'm changing this to be done only if the command succeeds.

> +	if (arg != NULL && os_strlen(arg) > 0) {

> +	} else if (os_strlen(arg) == 0)

And this not to dereference arg without checking that it is not NULL.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list