[PATCHv2] hostapd: reload bss mac files on SIGUSR2

[Antonio Quartulli]

On Mon, Jun 11, 2012 at 10:47:30AM +0300, Baruch Siach wrote:
> Hi Antonio,
> 
> On Mon, Jun 11, 2012 at 08:59:32AM +0200, Antonio Quartulli wrote:
> > On Mon, Jun 11, 2012 at 08:04:08AM +0300, Baruch Siach wrote:
> > > On Mon, Jun 11, 2012 at 12:44:30AM +0200, Antonio Quartulli wrote:
> > > > This patch allows the administrator to modify the provided MAC list for the
> > > > BSS ACL mechanism at runtime. In the current implementation no runtime change
> > > > is possible: if the MAC list is modified, hostapd has to be restart so
> > > > disconnecting all the current clients.
> > > > 
> > > > After manually modify the MAC files, the USR2 signal will make hostapd reload
> > > > them and possibly disconnect new not allowed stations.
> > > 
> > > Is there a reason not to use ctrl_iface?
> > 
> > mh..not really. I didn't think about that.
> > 
> > > It seems to me like a more natural interface than system global signal numbers.
> > 
> > In my mind I had the classic SIGHUP used to reload config files in general and
> > so I thought this was a good track.
> 
> Well, it is true that many daemons use SIGHUP to reload their configuration 
> files at run-time. I guess that reason for that is the lack of proper control 
> interface.
> 
> > Do you think it is better to move to ctrl_iface?
> 
> Once you have ctrl_iface in place, using it to reload a specific part of your 
> configuration should make for a better interface consistency, IMHO. Especially 
> so since ctrl_iface now supports SET/GET of arbitrary configuration 
> parameters.  One advantage of ctrl_iface is that it can report failure (e.g.  
> file not found, parsing failure) to the ctrl_iface client.

Well, that's true. But here I do not want to change any params, but I just want
to ask hostapd to re-read the files that it has read at startup. Moreover this
should probably be doable even if the ctrl_iface has not been activated.

Anyway, I'll think about that. Thank you for your feedback!

Cheers,

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
Url : http://lists.shmoo.com/pipermail/hostap/attachments/20120611/f5e5ebf1/attachment.pgp