[PATCH] Some align for config options

[Andrii Bordunov]

Ping ;) Jouni, what's your decision?
All the parts you've mentioned can be just stripped of course, but as
I've already told it would be better to list them somewhere, as for
me.



2012/5/10 Andrii Bordunov <andrew.bordunov at gmail.com>:
> Hi Jouni,
>
> Thank you for the explanations.
>
> Regarding all the specific / unstable features you've mentioned: I agree
> they shouldn't be mixed with usual ones, but the current state might be
> improved, as for me. I had several situations when I had to search the
> not enabled features through the code---of course it isn't critical, but
> it could be better for both using and developing if all working features
> would be documented somewhere with all appropriate warnings and
> description, IMHO.
>
> It may be either separate (experimental) section in existing config or
> maybe adding another file or anything else. It also should help to
> track features status, which might be useful when coming to release,
> for example.
>
> Regarding not used CONFIG_VALGRIND / WPA_MEM_DEFINED macros: it might be
> better to document even a such kind of things at the same experimental
> place just to let people know that such thing exists and can be used, to
> prevent reinventing a wheel ;)
>
> What do you think?
>
> ---
> Andrii Bordunov
>
>> From: Jouni Malinen <j at w1.fi>
>> To: hostap at lists.shmoo.com
>> Cc:
>> Date: Wed, 9 May 2012 22:30:37 +0300
>> Subject: Re: [PATCH] Some align for config options
>> On Wed, May 09, 2012 at 03:24:47PM +0300, Andrii Bordunov wrote:
>>> * Include following options to defconfig:
>>> * Remove following options from defconfig (are not supported anymore):
>>> * Remove OBJS_wpa var from Android makefile: there is no target using it.
>>
>> Thanks! Couple of comments below on areas that I don't think should be
>> included in the patch or well, at least should go into a separate patch
>> since they are blocking the less controversial parts from going int.
>>
>>> diff --git a/hostapd/defconfig b/hostapd/defconfig
>>
>>> +# Enable WPS NFC (Near Field Communication) method
>>> +#CONFIG_WPS_NFC=y
>>> +
>>> +# Enable WPS NFC support for NXP PN531 device
>>> +#CONFIG_WPS_NFC_PN531=y
>>> +
>>> +# Enable support for WPS USBA out-of-band mechanism
>>> +# with USB Flash Drives (UFD)
>>> +#CONFIG_WPS_UFD=y
>>
>> These are undocumented on purpose since they are way too difficult to
>> get working.
>>
>>> +# Enable validating WPS attributes in management frames
>>> +# and WSC messages (WPS 2.0)
>>> +#CONFIG_WPS_STRICT=y
>>> +
>>> +# Enable WPS testing operations
>>> +#CONFIG_WPS_TESTING=y
>>
>> These are undocumented since they are for very specific testbed purpose
>> and not meant for normal use.
>>
>>> diff --git a/wpa_supplicant/Android.mk b/wpa_supplicant/Android.mk
>>> diff --git a/wpa_supplicant/Makefile b/wpa_supplicant/Makefile
>>
>>> +ifdef CONFIG_VALGRIND
>>> +CFLAGS += -DCONFIG_VALGRIND
>>> +endif
>>
>> I don't think the WPA_MEM_DEFINED() macro is used anywhere in
>> hostap.git at the moment, so it does not look useful to define this
>> either.
>>
>>
>>> diff --git a/wpa_supplicant/defconfig b/wpa_supplicant/defconfig
>>
>>> +# Driver interface for Atheros driver
>>> +#CONFIG_DRIVER_ATHEROS=y
>>
>> This driver wrapper is only for hostapd, so it should not be mentioned
>> in wpa_supplicant/defconfig.
>>
>>> +# Enable WPS NFC (Near Field Communication) method
>>> +#CONFIG_WPS_NFC=y
>>> +
>>> +# Enable WPS NFC support for NXP PN531 device
>>> +#CONFIG_WPS_NFC_PN531=y
>>> +
>>> +# Enable support for WPS USBA out-of-band mechanism
>>> +# with USB Flash Drives (UFD)
>>> +#CONFIG_WPS_UFD=y
>>
>> Same as above, i.e., I would rather hide these until the implementation
>> is in more usable state.
>>
>>> +# Enable validating WPS attributes in management frames
>>> +# and WSC messages (WPS 2.0)
>>> +#CONFIG_WPS_STRICT=y
>>> +
>>> +# Enable WPS testing operations
>>> +#CONFIG_WPS_TESTING=y
>>
>> Same as above - extra complexity for very small use case.
>>
>>> +# Enable TDLS testing operations
>>> +#CONFIG_TDLS_TESTING=y
>>
>> This is in the same special use case category..
>>
>>> +# Enable DBus control interface
>>> +#CONFIG_DBUS=y
>>
>> Makefile does not use this, so this should not be added here. The real
>> build config options for the D-Bus interface (CONFIG_CTRL_IFACE_DBUS*)
>> are already mentioned.
>>
>>> +# Enable additional Valgrind support. Valgrind headers are required.
>>> +#CONFIG_VALGRIND=y
>>
>> See above - not used currently in hostap.git and no point in documenting
>> it here either.
>>
>> --
>> Jouni Malinen ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?PGP id EFC895FA