Can we remove the eloop exception listener?

Ben Greear greearb
Fri Jul 6 09:38:22 PDT 2012


On 07/04/2012 11:39 AM, Jouni Malinen wrote:
> On Mon, Jul 02, 2012 at 09:24:11PM -0700, Ben Greear wrote:
>> On 06/30/2012 03:24 AM, Jouni Malinen wrote:
>>> By the way, I just noticed that the poll() version of eloop seemed to
>>> break WPS external registrar functionality (TCP socket used for HTTP;
>>> i.e., something that needs both read and write events). I haven't had a
>>> chance to look at closer details on what was happening, but the HTTP
>>> connections were timing out in my tests. Going back to select() removed
>>> the issue.
>>
>> I don't think I've ever used that.  Do you have any details on
>> how to reproduce the problem and/or setup WPS external registrar?
>
> sudo ./wpa_supplicant -Dnone -ieth0 -c wps.conf -ddK
>
> (wps.conf can have just one line to enable the control interface, e.g.,
> with "ctrl_interface=DIR=/var/run/wpa_supplicant GROUP=admin")


> The problem here seems to be in registered EVENT_TYPE_WRITE for
> http_client_tx_ready() in src/wps/http_client.c not getting called which
> makes the HTTP client fail to send the POST data. Changing POLLIN to
> POLLOUT in eloop_sock_table_set_fds() for the writers table seems to fix
> this.

Yes, I saw your patch from the 4th.  It looks correct to me.

Thanks for finding and fix the bug.


Ben

-- 
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc  http://www.candelatech.com






More information about the Hostap mailing list