[PATCHv2] wpa_supplicant: support IBSS RSN STA authorization

[Antonio Quartulli]

On Sun, Jan 29, 2012 at 07:52:31PM +0200, Jouni Malinen wrote:
> On Sun, Jan 29, 2012 at 05:10:35PM +0100, Antonio Quartulli wrote:
> > In IBSS RSN cfg80211/mac80211 now waits for userspace to authorize new stations.
> > This patch makes wpa_supplicant notify the driver when a station can be
> > considered authorised.
> 
> > - If the kernel has not been patched already with the corresponding
> > "cfg80211/mac80211: userspace peer authorization in IBSS" patch, the
> > set_station message will simply return EINVAL and wpa_s will continue to work
> > as usual.
> 
> I prefer to wait with this until the kernel patch gets approved and
> pushed into wireless-testing.git.

ok!

> 
> > diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
> > @@ -6427,6 +6427,9 @@ retry:
> >  		NLA_PUT(msg, NL80211_ATTR_MAC, ETH_ALEN, params->bssid);
> >  	}
> >  
> > +	if (params->key_mgmt_suite == KEY_MGMT_802_1X)
> > +		NLA_PUT_FLAG(msg, NL80211_ATTR_CONTROL_PORT);
> 
> Could you please explain what this is trying to do? It does not look
> correct taking into account that I would assume similar control port
> behavior to be used with KEY_MGMT_802_1X, KEY_MGMT_PSK,
> KEY_MGMT_802_1X_SHA256, and KEY_MGMT_PSK_SHA256.

well, First of all let me say that I'm not really familiar with all those
define, and I probably need to reserve some time to read and understand them
all.

The idea is that in case of creating a  RSN protected IBSS network, wpa_s has to
tell the kernelspace that such network is RSN protected. But probably I got it
wrong and such comparison should be done against WPA_KEY_MGMT_PSK instead of
KEY_MGMT_802_1X.

Can KEY_MGMT_802_1X_SHA256 and KEY_MGMT_PSK_SHA256 be allowed values for
params->key_mgmt_suite in IBSS_RSN?

Cheers,

> 
> -- 
> Jouni Malinen                                            PGP id EFC895FA
> _______________________________________________
> HostAP mailing list
> HostAP at lists.shmoo.com
> http://lists.shmoo.com/mailman/listinfo/hostap

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara