[PATCH] build: allow overriding D-Bus version from pkg-config

[Grant Erickson]

On Wed, Jan 4, 2012 at 3:12 PM, Dan Williams <dcbw at redhat.com> wrote:
> On Wed, 2012-01-04 at 14:37 -0800, Grant Erickson wrote:
>> This allows the package build to specify the D-Bus version being built
>> against externally to pkg-config.
>
> What does this actually do?  I don't see DBUS_VERSION actually used
> anywhere in the wpa_supplicant code or makefiles, nor is it used in the
> D-Bus headers.  Perhaps we should just remove those pieces?

Dan,

I've no idea what the intent originally was or what it is supposed to do
today.

Searching through existing packages in my current project indicates that
avahi is doing something similar and has some conditional code based on the
extracted major and minor values:

% grep -ri 'DBUS_VERSION\(_MAJOR\|_MINOR\)' avahi/ connman/ dbus/ hostap/
libnih/ upstart/ | files -su
avahi/avahi-0.6.28/avahi-common/dbus-watch-glue.c
avahi/avahi-0.6.28/avahi-daemon/dbus-protocol.c
avahi/avahi-0.6.28/configure
avahi/avahi-0.6.28/configure.ac
hostap/hostap/wpa_supplicant/Android.mk
hostap/hostap/wpa_supplicant/dbus/Makefile
hostap/hostap/wpa_supplicant/Makefile

However, beyond the cited make files, hostap does nothing with them nor
does D-Bus itself.

That said, I am OK with getting rid of the checks altogether.

-Grant
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.shmoo.com/pipermail/hostap/attachments/20120104/33598ed3/attachment.htm