[PATCH] dbus: Making the peer's properties acessible separately

Flávio Ceolin flavio.ceolin
Mon Feb 6 11:03:37 PST 2012


Hi  Reinette

On Mon, Feb 6, 2012 at 3:50 PM, Reinette Chatre
<reinette.chatre at intel.com> wrote:
> Hi Dan,
>
> On Mon, 2012-02-06 at 09:40 -0600, Dan Williams wrote:
>> If you want to maintain backwards compatibility, just break the
>> properties out like your patch did, but *also* retain the 'Properties'
>> property from the old code. ?Thus it wouldn't break current users, but
>> we'd take advantage of GetAll.
>
> Can this perhaps be avoided? There has not been an official
> wpa_supplicant release with P2P so I don't think backwards compatibility
> is a major issue here. I think having two places in the D-Bus API with
> the same properties available will introduce a lot of confusion. In
> addition to the confusion, if we now proceed with an official release
> with the two spots for properties the original somehow (any ideas?)
> needs to be marked as deprecated (in the first release it is
> available :) ) and hopefully removed at some point, otherwise it will
> need to be carried forever, which I think will be unnecessary burden and
> a potential source of inconsistencies.
>
> Reinette
>
>

That's exactly what I think. As we don't have an official release, it seems to
be an error this kind of inconsistency.

BR,
Fl?vio Ceolin



More information about the Hostap mailing list