[PATCH] dbus: Making the peer's properties acessible separately

[Dan Williams]

On Fri, 2012-02-03 at 21:30 -0200, Fl?vio Ceolin wrote:
> Hi Jouni and Reinette,
> 
> On Fri, Feb 3, 2012 at 8:01 PM, Reinette Chatre
> <reinette.chatre at intel.com> wrote:
> > Hi Jouni and Fl?vio,
> >
> > On Fri, 2012-02-03 at 23:13 +0200, Jouni Malinen wrote:
> >> On Fri, Feb 03, 2012 at 06:52:18PM -0200, Fl?vio Ceolin wrote:
> >> > How there is the method org.freedesktop.DBus.Properties.GetAll
> >> > that returns all properties from a specific interface, makes more
> >> > sense separate the properties to be possible to get only a specific
> >> > property using the method org.freedesktop.DBus.Properties.Get.
> >>
> >> While this may be a good change from the design view point, I'm a bit
> >> worried about changing this interface if it breaks existing applications
> >> that use the interface. The P2P extensions are relatively recent, so
> >> this could still be acceptable, but I'm not going to apply this in the
> >> current form until I hear an ack or two from people who are using this
> >> interface.
> >
> > We are using this interface and can support this change. Since this is
> > an API change, could you please support this going to hostap-1? I take
> > the liberty to add that new tag below.
> >
> > Acked-by: Reinette Chatre <reinette.chatre at intel.com>
> > intended-for: hostap-1
> >
> > Fl?vio: I am just curious ... are you planning a similar change to the
> > P2PDeviceProperties on the P2PDevice interface?
> >
> > Reinette
> >
> >
> > _______________________________________________
> > HostAP mailing list
> > HostAP at lists.shmoo.com
> > http://lists.shmoo.com/mailman/listinfo/hostap
> 
> Thanks for the feedback folks.
> 
> Reinnet, answering your question, yes I've plan to do it,
> I'm just waiting the feedback for these changes.
> 
> I think it's a good time to do it since this code is still
> recent.

If you want to maintain backwards compatibility, just break the
properties out like your patch did, but *also* retain the 'Properties'
property from the old code.  Thus it wouldn't break current users, but
we'd take advantage of GetAll.

Dan