Android proposal (Android.mk) - to be compilant with hostap directory structure - current build fail.

[Dmitry Shmidt]

On Wed, Mar 16, 2011 at 9:25 AM, Janusz Dziedzic
<janusz.dziedzic at gmail.com> wrote:
> Still require changes.
>
> From my point of view this should look like this:
> 1) we go eg. to external/ directory
> 2) get latest hostap (eg. via git clone ...)
> 3) we run mmm external/hostap/wpa_supplicant
> And wpa_supplicant should compile without any modification.
>
> I suspect this Android.mk we have already in current is from Android
> structure, where we have only external/wpa_supplicant directory - and
> because of that problems with src and paths.
> Why Android don't have same directory structure like hostap
> (external/hostap/wpa_supplicant)? This required a work during each
> update/integration (adding community patches).
>
> BR
> Janusz
>
> 2011/3/16 Simon <mengxipeng at gmail.com>:
>> I've compiled wpa_supplicant ?on android platform successfully.
>> I only wrote a Android.mk in the wpa_supplicant subdirectory to
>> compile the wpa_supplicant and wpa_cli.
>> I think my Android.mk is not very good, because i do not using macros.
>> anyway i can run the wpa_supplicant and wpa_cli on my android box.
>>
>>
>>
>> Meng Xipeng
>> Software Engineer
>> moore chip Technology
>> Mobile?+86-1353-785-3751
>> E-mail?mengxipeng at gmail.com
>> MSN:meng_xi_peng at hotmail.com
>> QQ:64210596
>> Web Site:http://www.moorechip.com
>>
>> Please consider the environment before printing this e-mail
>>
>>
>>
>>
>>
>> On Tue, Mar 15, 2011 at 7:42 PM, Jouni Malinen <j at w1.fi> wrote:
>>> On Mon, Mar 14, 2011 at 08:20:12AM +0100, Janusz Dziedzic wrote:
>>>> Problem connected with Android build.
>>>> I see some issue with hostap/wpa_supplicant/Android.mk. Seems all
>>>> files/paths are added with src/.... prefix (eg. src/utils/common.c).
>>>> There is a compilation issue because of that. We don't have
>>>> hostap/wpa_supplicant/src directory.
>>>
>>> Correct. The Android build system does not seem to be prepared for the
>>> directory structure used in wpa_supplicant/hostapd and the workaround
>>> for that is to include the src directory under wpa_supplicant/hostapd.
>>> The old versions in the Android trees have done this type of move in the
>>> repository; I'm using a symlink in my tests.
>>>
>>>> What I propose
>>>> 1) we can create a src symlink in hostap/wpa_supplicant/ that will
>>>> point to ../src
>>>
>>> I'm doing exactly this manually. I would hope that the same thing can be
>>> added automatically from the Android.mk file, but I have not tested that
>>> yet.
>>>
>>>> 2) we can change all paths from src/ to ../src/ in Android.mk
>>>
>>> If I've understood correctly, this won't be acceptable with the current
>>> Android build mechanism.
>>>
>>> --
>>> Jouni Malinen ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?PGP id EFC895FA
>>> _______________________________________________
>>> HostAP mailing list
>>> HostAP at lists.shmoo.com
>>> http://lists.shmoo.com/mailman/listinfo/hostap
>>>
>>
>> _______________________________________________
>> HostAP mailing list
>> HostAP at lists.shmoo.com
>> http://lists.shmoo.com/mailman/listinfo/hostap
>>
>>
>
>
>
> --
> Janusz Dziedzic
> _______________________________________________
> HostAP mailing list
> HostAP at lists.shmoo.com
> http://lists.shmoo.com/mailman/listinfo/hostap
>

Hi,

I am not sure that your proposal is the same but we can do the next thing:
1) Create small Android.mk in wpa_supplicant "root" directory (where
README and COPYING) are located.
2) It will include makefiles from hostapd and wpa_supplicant subdirectories
The only drawback is that we can not create executable with the same
name as subdirectory, so we will need
to rename wpa_supplicant  and hostapd subdirs to something else.

Will it be acceptable ?

Thanks,

Dmitry