[PATCH] Add dbus signal for information about server certification

Jouni Malinen j
Sat Jun 25 05:38:05 PDT 2011


On Mon, Jun 20, 2011 at 12:39:52PM +0800, Michael Chang wrote:
> In general, this patch attemps to extend commit
> 00468b4650998144f794762206c695c962c54734 with dbus support.
> 
> This can be used by dbus client to implement subject match text
> entry with preset value probed from server. This preset value, if
> user accepts it, is remembered and passed to subject_match config
> for any future authenication.

Thanks! I would agree with the other comments that there is not much
point in using a hexdump of binary data over D-Bus, so I hope that you
can modify this to address that part for the certificate data. In
addition, the patch broke the build here:

> diff --git a/wpa_supplicant/dbus/dbus_new.c b/wpa_supplicant/dbus/dbus_new.c
> @@ -2216,6 +2253,12 @@ static const struct wpa_dbus_property_desc wpas_dbus_interface_properties[] = {
>  	  (WPADBusPropertyAccessor) wpas_dbus_getter_networks,
>  	  NULL, R
>  	},
> +	{ "Certification", WPAS_DBUS_NEW_IFACE_INTERFACE,
> +	  {
> +		  { "certification", "a{sv}", ARG_OUT },
> +		  END_ARGS
> +	  }
> +	},
>  #ifdef CONFIG_WPS
>  	{ "ProcessCredentials", WPAS_DBUS_NEW_IFACE_WPS, "b",
>  	  (WPADBusPropertyAccessor) wpas_dbus_getter_process_credentials,

Is that really in the correct data structure or is this a merge error of
some sort?

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the Hostap mailing list