[PATCH 5/6] P2P: Add WpsFailed signal in P2P D-Bus.

Jouni Malinen j
Sat Jun 25 01:47:40 PDT 2011

On Thu, Jun 09, 2011 at 04:41:02PM +0000, Sane, Jayant wrote:
> Signal is triggered if an error occurs during wps exchange phase.

Thanks! I applied for other parts, but I removed cancellation of the
group formation timeout since I did not see how that would need to be in
this type of addition:

> diff --git a/wpa_supplicant/p2p_supplicant.c b/wpa_supplicant/p2p_supplicant.c
> +void wpas_p2p_wps_failed(struct wpa_supplicant *wpa_s,
> +			 struct wps_event_fail *fail)
> +{
> +	if (!wpa_s->p2p_in_provisioning) {
> +		wpa_printf(MSG_DEBUG, "P2P: Ignore WPS fail event - P2P "
> +			   "provisioning not in progress");
> +		return;
> +	}
> +	eloop_cancel_timeout(wpas_p2p_group_formation_timeout, wpa_s->parent,
> +			     NULL);
> +	wpas_notify_p2p_wps_failed(wpa_s, fail);
> +}

What is the purpose of canceling group formation timeout here? Please
note that it was not previously done at this point in the process and
the group formation failure needs to be indicated here. As such, either
this eloop_cancel_timeout() call should not be here or this would need
to call wpas_group_formation_completed(wpa_s, 0).

Jouni Malinen                                            PGP id EFC895FA

More information about the Hostap mailing list