[PATCH 1/2] Change wpa_printf to wpa_msg in scan.c
Thu Feb 10 10:39:00 PST 2011
On 02/10/2011 10:27 AM, Jouni Malinen wrote:
> Thanks! I applied following patches:
> I removed couple of changes that passed in NULL as the counter pointer
> since I see no point in using wpa_msg() instead of wpa_printf() in such
> cases. In addition, I introduced a new function (or well, pre-processor
> macro), wpa_dbg(), that can be used like wpa_msg(), but which can be
> compiled out from CONFIG_NO_STDOUT_DEBUG=y builds. This is needed to
> avoid noticeable increase in the binary size for builds that do not need
> verbose debugging.
One thing about passing null to wpa_msg: Doesn't that
allow us to get messages over the cli interface tool, where
wpa_printf does not?
It seemed to me that converting all wpa_printfs to wpa_msg
(or wpa_dbg) was going to be more flexible going forward.
We could do a check for NULL and instead of printing
"NULL:" is my patches did, it could just leave out the "NULL:",
or maybe make more informed decisions about passing to
the cli, log files, etc.
But, either way is fine with me.
Ben Greear <greearb at candelatech.com>
Candela Technologies Inc http://www.candelatech.com
More information about the Hostap