[PATCH 2/4] P2P: Add Notice Of Absence interval param

[Jouni Malinen]

On Wed, Dec 07, 2011 at 07:58:21AM +0100, Janusz Dziedzic wrote:
> 2011/12/6 Jouni Malinen <j at w1.fi>:
> > On Mon, Nov 28, 2011 at 02:11:36PM +0200, Janusz.Dziedzic at tieto.com wrote:
> >> NOA interval param is required during set_noa
> >> and NOA notification.
> >
> > Could you please describe the use case for this? set_noa() is really a
> > testing only functionality in wpa_supplicant and I would expect real
> What with certification case - we have to setup somehow NOA values
> requested from testTool?

Well, I guess that depends on what certification you are thinking of,
but the ones I've seen, do not require this extra parameter.

> > life NoA management to be handled by the driver. For common use cases of
> > set_noa(), I would expect the interval to be set automatically based on
> > the Beacon interval.
> Do you suggest NOA interval should be same as Beacon interval?

Yes.

> Yes, this is case for using larger interval.
> eg.
> interval = 2s
> duration = 1s

OK.. That would be pretty painful for most use cases, but possible, I'd
guess.

> Regarding resolution, I only add some functionality to API that
> currently exists - duration is also in ms.

The problem with this is that you cannot represent the most common test
case I'm aware of (Beacon interval = 100 TU, i.e., 102.4 ms and NoA
interval same as Beacon interval).

> Anyway I think this could be usefull for test + some certification case.

It sounds pretty specific test case, but anyway, I'm not going to accept
this type of modification of the existing command if it breaks use of
current mechanism with interval hardcoded to match with the Beacon
interval.

-- 
Jouni Malinen                                            PGP id EFC895FA