[PATCH 1/2] hostap: set ht_capab from wiphy when in P2P GO mode

Arik Nemtsov arik
Sat Aug 6 23:00:00 PDT 2011


On Sat, Aug 6, 2011 at 22:15, Jouni Malinen <j at w1.fi> wrote:
> On Sun, Jul 31, 2011 at 09:45:04PM +0300, Arik Nemtsov wrote:
>> Set the HT capabilities of a P2P GO according to the supported ones in
>> wiphy. In addition enable WMM when 802.11n is enabled.
>
> Isn't wmm_enabled already set (the default hostapd config sets it to -1
> and that is then converted into ieee80211n)?

Yea you're right. Haven't noticed this one. I'll remove this line from
the patch.

>
> I'm not completely sure I would like to get all HT capabilities enabled
> in this way by default based on driver capabilities. Doesn't this leave
> things in inconsistent state (e.g., HT_CAP_INFO_SUPP_CHANNEL_WIDTH_SET
> set, but secondary_channel not)?

Yes this specific setting seems problematic. I guess for now we can
just mask out this bit in the received ht_capab?

Arik



More information about the Hostap mailing list